Eliminate legacy interface and obsolete large_data option #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobachetti
force-pushed
the
eliminate_legacy_interface
branch
2 times, most recently
from
e043801 to
83a4b9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 97.14% 93.01% -4.13%
==========================================
Files 42 41 -1
Lines 7941 7387 -554
==========================================
- Hits 7714 6871 -843
- Misses 227 516 +289
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matteobachetti
force-pushed
the
eliminate_legacy_interface
branch
from
9917860 to
6908e95
Compare
matteobachetti
force-pushed
the
eliminate_legacy_interface
branch
from
6908e95 to
5f876b3
Compare
matteobachetti
force-pushed
the
eliminate_legacy_interface
branch
from
2fc764e to
05b70a8
Compare
dhuppenkothen
approved these changes
Sep 22, 2023
matteobachetti
force-pushed
the
eliminate_legacy_interface
branch
from
05b70a8 to
524d846
Compare
|
Good point. I now marked the change as breaking in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those interfaces were already largely discouraged. The large_data infrastructure was incomplete and buggy, while the legacy interface was very slow.
This PR is in preparation of our next major release, where we can afford breaking some minor things. It eliminates these two mechanisms, making the code lighter and avoiding confusion in users.
While doing this, I had to also revise a little the mechanism of
save_all, that needed the legacy interface and allowed to load all the sub-periodograms of the averaged periodogram in memory. It was used also from _create_matrix in DynamicalPowerspectrum. The result is not bad, because to do this we are basically avoiding creating a bunch ofAveragedPowerspectrumobject for each sub spectrum.