Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative GTI failure #787

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Conversation

matteobachetti
Copy link
Member

Responding to an issue by G.L. Israel, I substituted a generic exception with a full traceback of what goes wrong when GTIs are not correctly read.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc9d575) 96.31% compared to head (065e3cc) 96.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          43       43           
  Lines        8495     8497    +2     
=======================================
+ Hits         8182     8184    +2     
  Misses        313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Dec 29, 2023

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-02 17:01:33 UTC

@matteobachetti matteobachetti force-pushed the more_informative_gti_failure branch from c9db9b6 to 6440df1 Compare December 31, 2023 13:16
Copy link
Collaborator

@mgullik mgullik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely makes it more clear what is the error.

Just a thought, could it make sense to set a GTI keyword when reading the fits file?
The default would be the case it is now, but we could give the user the possibility to choose the GTI keyword if they know it for that specific mission.

@matteobachetti
Copy link
Member Author

@mgullik indeed, there is a keyword, gtistring, that allows the user to provide a number of comma-separated strings for GTI extensions. The default is "GTI,STDGTI", or whatever the default for a given mission is

@matteobachetti matteobachetti added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 490a7c7 Jan 3, 2024
16 checks passed
@matteobachetti matteobachetti deleted the more_informative_gti_failure branch January 3, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants