-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More informative GTI failure #787
Conversation
d8fff48
to
7c824d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 43 43
Lines 8495 8497 +2
=======================================
+ Hits 8182 8184 +2
Misses 313 313 ☔ View full report in Codecov by Sentry. |
Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-01-02 17:01:33 UTC |
c9db9b6
to
6440df1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely makes it more clear what is the error.
Just a thought, could it make sense to set a GTI keyword when reading the fits file?
The default would be the case it is now, but we could give the user the possibility to choose the GTI keyword if they know it for that specific mission.
@mgullik indeed, there is a keyword, |
Responding to an issue by G.L. Israel, I substituted a generic exception with a full traceback of what goes wrong when GTIs are not correctly read.