Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/full invert crash 2942 #2957

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Fix/full invert crash 2942 #2957

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a15ffa9
fix: Resolve Full-Invert crash caused by file permissions
Abdurrahman-shaikh Feb 16, 2025
2b6a2df
Clean up temporary file with deleteOnExit
Abdurrahman-shaikh Feb 16, 2025
b106498
Clean up temporary files immediately with try-finally
Abdurrahman-shaikh Feb 16, 2025
5e65ad7
Clean up temporary files immediately with try-finally
Abdurrahman-shaikh Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/stirling/software/SPDF/utils/misc/InvertFullColorStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ private void invertImageColors(BufferedImage image) {

// Helper method to convert BufferedImage to InputStream
private File convertToBufferedImageTpFile(BufferedImage image) throws IOException {
File file = new File("image.png");
File file = File.createTempFile("image", ".png");
ImageIO.write(image, "png", file);
//Ensures temp file is deleted when jvm terminates
file.deleteOnExit();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete on exit isn't enough since this server could be running for weeks or months, we must delete it after operation
Can you replace this with a try finally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete on exit isn't enough since this server could be running for weeks or months, we must delete it after operation Can you replace this with a try finally?

Ok, I will replace it with a try-finally block

return file;
}
}
Loading