Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages #796

Merged
merged 8 commits into from
Feb 11, 2024
Merged

Languages #796

merged 8 commits into from
Feb 11, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Feb 9, 2024

Description

Removed several spaces, added missing strings for German, corrected typos

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner February 9, 2024 22:47
@Frooodle
Copy link
Member

Appreciate these changes and the ones that keep coming, am i good to merge?

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 11, 2024

I still have a few corrections, if you want I can also open a new PR for it and you can merge them here.

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 11, 2024

@Frooodle Sorry for the offtopic, but can you tell me why action="/api/v1/general/crop" and th:action="@{api/v1/misc/auto-split-pdf}" exist ?
You can merge the PR, thanks.

@Frooodle
Copy link
Member

Frooodle commented Feb 11, 2024

Not sure what you mean by the question, like what purpose do they serve and what do they do to the document or...? The action param itself or?

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 11, 2024

I don't see any guideline why one should work with @{...} expression and one without.

@Frooodle
Copy link
Member

Ahh right so thymeleaf one does some extra things
When just used with 2 static plain text entries it still functions differently

For instance it can auto add context paths and other things
Why I switch between them... I shouldn't
This must be when I was testing which to use

One is faster to use
one is more flexible with weird nginx paths

Still never decided but generally they function same

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 11, 2024

It drove me crazy, I can't deal with it. Maybe a constant line should be established to avoid any confusion (on my part :-D).

@Frooodle
Copy link
Member

Yeah certainly should be constant throughout

@Frooodle
Copy link
Member

oh man those conflicts :(

@sbplat sbplat merged commit e84f9c5 into Stirling-Tools:main Feb 11, 2024
3 checks passed
@sbplat
Copy link
Member

sbplat commented Feb 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants