Update-helm-chart

[sharifm-informatica]

Description

• update app version in helm chart
• Correct and update UI env variables in chart values

Checklist:

• [ x] I have read the Contribution Guidelines
• [ x] I have performed a self-review of my own code
• [ x] I have commented my code, particularly in hard-to-understand areas
• [ x] My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

[Frooodle]

Really need to automate that versio number..

[Ludy87]

Hi @Frooodle, is there a dependency on

Stirling-PDF/build.gradle

Line 15 in 6fc9c7b

version = '0.21.0'

[Frooodle]

that version number in gradle is what controls the version number everywhere

[Ludy87]

The question is whether the version in the build.gradle should also be in the Chart.yaml.

[Frooodle]

yes

[Ludy87]

What do you think of this:
https://github.com/Ludy87/Stirling-PDF/blob/sync_versions/.github/workflows/sync_versions.yml
https://github.com/Ludy87/Stirling-PDF/blob/sync_versions/.github/scripts/gradle_to_chart.py

[Frooodle]

seems over engineered :P
but fine by me !

[Ludy87]

You can push it yourself, otherwise I need the time resources :P

[sharifm-informatica]

Unless we are auto testing the chart deployment, maybe we should not automate the version upgrades. To recap:

• auto tests first
• auto deploy updates to chart second
  But I love what you did.

[Ludy87]

I have only provided it; I leave the decision to the maintainers of the repo.