Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIS switched to Google OAuth #182

Closed
drewvolz opened this issue Aug 29, 2016 · 7 comments · Fixed by #192
Closed

SIS switched to Google OAuth #182

drewvolz opened this issue Aug 29, 2016 · 7 comments · Fixed by #192
Labels
bug/general WIP Work in progress
Milestone

Comments

@elijahverdoorn
Copy link
Contributor

See #184

@hawkrives hawkrives changed the title SIS switched to Google OAtuh SIS switched to Google OAuth Aug 31, 2016
@hawkrives
Copy link
Member

#184 is almost all of this. We still need two things:

  1. The SIS view needs to handle the case where the token is revoked between requests. All invalid token errors (we know because we'll get the login page again) should result in the user being shown the Login screen again.
  2. We need to investigate how long it the token lasts for. It's a session cookie, but I don't know what session means outside of the context of a web browser.

@hawkrives
Copy link
Member

Ideally, we could get an OAuth token for the SIS itself (ish), which wouldn't expire until the user changed their password or revoked the token, but that's going to need to wait until we (Elijah) talks to IT.

@elijahverdoorn
Copy link
Contributor

I have had users report the crash that we are working to fix. Just posting that here so that we know that users are noticing.

@drewvolz
Copy link
Member Author

drewvolz commented Sep 3, 2016

Hah yeah. They're definitely all going to notice because their cookie expires and then the SIS tab crashes

@hawkrives hawkrives mentioned this issue Sep 3, 2016
@hawkrives
Copy link
Member

I'm reasonably sure that #192 is complete and working now.

@drewvolz
Copy link
Member Author

drewvolz commented Sep 3, 2016

I will defer my judgement to @elijahverdoorn if we would like to test this secondhand before integration. I'm currently without computer for the Labor Day weekend.

@hawkrives hawkrives added the WIP Work in progress label Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/general WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants