Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth stuff #184

Merged
merged 11 commits into from
Sep 1, 2016
Merged

Oauth stuff #184

merged 11 commits into from
Sep 1, 2016

Conversation

hawkrives
Copy link
Member

I can't do any more tonight. This is what I've got so far, but both simulators are fighting me. iOS says it can't find CFBundleIdentifier, and Android is throwing an invariant of "please link the damned library with rnpm link" (paraphrased).

But this might work? It's a copy of https://github.com/ryanmcdermott/react-native-login/tree/master/ReactNativeLogin, and if I understand correctly, the cookies are cached by the underlying network layer, not the webview, so once we get a login here it should just work for the other fetch requests. (see facebook/react-native#1274 (comment))

One of you is going to have to take this on, I'm afraid.

@hawkrives
Copy link
Member Author

/cc @elijahverdoorn @drewvolz

@drewvolz
Copy link
Member

drewvolz commented Aug 30, 2016

Speaking from the iOS side of things, I see the same error on iOS if I try building and running with npm run ios (without pulling in these changes). However, if I run with Xcode, all is well. That is a band-aid and it does not fix the problem, but it is a way that we can still build and run on iOS at the very least.

@elijahverdoorn
Copy link
Contributor

This is the cause of the rnpm link issues: joeferraro/react-native-cookies#37

@hawkrives
Copy link
Member Author

I used react-native link first… let's try removing the commit that added them, then installing the package, then react-native link.

And make sure not to commit the Info.plist changes. React Native and Xcode have different ideas about how it should be formatted.

@hawkrives
Copy link
Member Author

Can I merge this to master?

@drewvolz
Copy link
Member

drewvolz commented Aug 31, 2016

I found one more condition.

  1. Login via settings
  2. Logout via settings
  3. Try to load the SIS tab. It loads, and has a cached token. Oops.
  4. Pull down to load the financials view, or load the courses
  5. Crash/red screen, and errors/warnings

Financials
screen shot 2016-08-31 at 8 28 39 am

Courses
screen shot 2016-08-31 at 8 31 27 am

@hawkrives
Copy link
Member Author

Fixed in the latest commit.

@drewvolz
Copy link
Member

drewvolz commented Sep 1, 2016

:shipit:

@hawkrives hawkrives merged commit c3fa532 into master Sep 1, 2016
@hawkrives hawkrives deleted the oauth branch September 1, 2016 02:20
@drewvolz drewvolz added the pr ✓ label Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants