-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth stuff #184
Oauth stuff #184
Conversation
Speaking from the iOS side of things, I see the same error on iOS if I try building and running with |
This is the cause of the |
I used react-native link first… let's try removing the commit that added them, then installing the package, then react-native link. And make sure not to commit the Info.plist changes. React Native and Xcode have different ideas about how it should be formatted. |
Can I merge this to |
Fixed in the latest commit. |
I can't do any more tonight. This is what I've got so far, but both simulators are fighting me. iOS says it can't find CFBundleIdentifier, and Android is throwing an invariant of "please link the damned library with
rnpm link
" (paraphrased).But this might work? It's a copy of https://github.com/ryanmcdermott/react-native-login/tree/master/ReactNativeLogin, and if I understand correctly, the cookies are cached by the underlying network layer, not the webview, so once we get a login here it should just work for the other
fetch
requests. (see facebook/react-native#1274 (comment))One of you is going to have to take this on, I'm afraid.