Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search courses by short/long title, description #2341

Closed
drewvolz opened this issue Feb 14, 2018 · 6 comments
Closed

Search courses by short/long title, description #2341

drewvolz opened this issue Feb 14, 2018 · 6 comments

Comments

@drewvolz
Copy link
Member

drewvolz commented Feb 14, 2018

I think we’re only searching by short title right now. Use:

Algorithms and Data Structures reveals that “Algorithms/Data Struc” is searchable but the long title containing “Structures” is not

@hannesmcman
Copy link
Member

Should we add "search by course description" to this as well?

@drewvolz
Copy link
Member Author

Sure

@drewvolz drewvolz changed the title Search courses by both titles Search courses by short/long title, description Feb 15, 2018
@drewvolz
Copy link
Member Author

Professor name causes me a problem. Searching for “Olaf Hall-Holt” does not return anything because it matches on “Olaf A. Hall-Holt”

@hawkrives
Copy link
Member

Pull up a node repl and see if https://github.com/bevacqua/fuzzysearch handles that match

@drewvolz
Copy link
Member Author

drewvolz commented Feb 16, 2018

Ran

const fuzzysearch = require("fuzzysearch")
fuzzysearch('Olaf Hall-Holt', 'Olaf A. Hall-Holt')

Returns

true

https://runkit.com/drewvolz/5a873ff54612ac00128e7682

@rye
Copy link
Member

rye commented Feb 16, 2018

Fuzzy is probably better, IMHO. People are more likely to make mistakes or be lazy on mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants