-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course search enhancements #2383
Conversation
* Fuzzy search * Search titles
New dependencies added: fuzzysearch. fuzzysearchAuthor: Nicolas Bevacqua Description: Tiny and blazing-fast fuzzy search in JavaScript Homepage: https://github.com/bevacqua/fuzzysearch
|
iOS ReportAnalysis of slow build times (>20s)
Generated by 🚫 dangerJS |
Do we want to add search by description here? (course.description || []).some(description =>
description.toLowerCase().includes(query)
) |
Maybe. Thoughts, anyone else? @rye @hawkrives |
I feel like searching description is going to generate false positives and be really slow. I'd like some benchmarks on search speed with and without description searching. Just log performance.now before and after the filter process happens. |
With that said, I'd be fine with merging this PR as-is, and checking on description searching in a followup. |
Are you alright with merging these changes, @hannesmcman? |
Closes #2341
The titles are additional to the course names.
Does not solve searching for names where middle initials prevent a match in prof names