Change credential_id_sha256 data type for MySQL compatibility
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL has issues creating an index on binary field, requiring special instructions. It is better to go with a slightly more compatible implementation that utilizes plain CharField than to write special edge-case instructions just for MySQL. Squashed migration necessary to avoid ever executing migration code that crashes on MySQL. See #17
|
Thanks, this seems to work just fine in our CI for both MySQL and PostgreSQL: https://github.com/WeblateOrg/weblate/actions/runs/10217762479/job/28272321602?pr=12173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
MySQL has issues creating an index on binary field, requiring additional instructions for it to work. I feel it is better to go with a slightly more compatible implementation that utilizes plain CharField than to write special 'edge-case' instructions just for MySQL.
Squashed migration necessary to avoid ever executing migration code that crashes on MySQL.
@nijel could you please give this PR a try and see if it resolves your issue? I think you will like it!