-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default-features = false
for reqwest dependency
#335
Comments
jqnatividad
added a commit
to jqnatividad/jsonschema-rs
that referenced
this issue
Jan 23, 2022
fixes Stranger6667#335 . Otherwise, reqwest will always use default-tls which is the native-tls even if jsonschema `reqwest-rustls-tls` feature is specified.
Hi @jqnatividad Glad you find the library helpful :) Thank you for opening this issue, sure, the proposed change makes complete sense and I'll take a look at #336 shortly |
Stranger6667
pushed a commit
that referenced
this issue
Jan 23, 2022
fixes #335 . Otherwise, reqwest will always use default-tls which is the native-tls even if jsonschema `reqwest-rustls-tls` feature is specified.
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, thanks @Stranger6667 for this amazing library as it allows qsv to validate CSVs.
However, we're having difficulty building binaries using cross as the reqwest dependency brings in native-tls by default, which in turn pulls in openssl which is no longer supported by cross (cross-rs/cross#229), even if I take advantage of the jsonschema's reqwest-rustls-tls feature.
Would it be possible to set
default-features = false
in the reqwest dependency?In that way, jsonschema users can specify which tls they want to use and the reqwest dependency forwarding feature actually works as expected.
The text was updated successfully, but these errors were encountered: