add build arg and build context args #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khizunov
force-pushed
the
anton/add-build-arg-and-context
branch
from
9c0f32c
to
687ccca
Compare
ofir-amir
reviewed
Dec 26, 2023
Guilty, forgot to disable auto-format. |
khizunov
force-pushed
the
anton/add-build-arg-and-context
branch
3 times, most recently
from
acd9afb
to
ed0b246
Compare
ofir-amir
requested changes
Dec 27, 2023
tests/test_cli.py
Outdated
There was a problem hiding this comment.
I this test config from skipper.yaml only or also from CLI or you expect to be handled by click?
There was a problem hiding this comment.
@ofir-amir this test is testing builder functionality.
There was a problem hiding this comment.
oops - the question was on tests/test_config.py
There was a problem hiding this comment.
these tests are only for config file. CLI verified by test_cli
khizunov
force-pushed
the
anton/add-build-arg-and-context
branch
from
ed0b246
to
6c87cbb
Compare
ofir-amir
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.