Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reward converter - Create/Update/Delete TradeRoute unit tests #1015

Merged
merged 5 commits into from
Dec 8, 2023
Merged

reward converter - Create/Update/Delete TradeRoute unit tests #1015

merged 5 commits into from
Dec 8, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Dec 5, 2023

Brief Changelog

  • Added unit tests for create, update, and delete trade routes
  • Update MockClientsAndConnections helper so that it has enough state to register ICAs
  • Added helper function to mock out an ICA address (useful if you need to do more than one ICA)

@sampocs sampocs changed the title reward converter - msg_server unit tests (Create/Update/DeleteTradeRoute) reward converter - Create/Update/Delete TradeRoute unit tests Dec 5, 2023
ethan-stride
ethan-stride reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/apptesting/test_helpers.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route_test.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route_test.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route_test.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route_test.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_update_trade_route_test.go Show resolved Hide resolved
@sampocs sampocs merged commit 6704631 into autoswap-revenue-tokens Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-stride ethan-stride ethan-stride left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @ethan-stride