Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autopilot liquid stake and forward unit tests #1041

Merged
merged 9 commits into from
Jan 4, 2024
Merged

autopilot liquid stake and forward unit tests #1041

merged 9 commits into from
Jan 4, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Jan 3, 2024 •
edited
Loading

Context

Fixed, cleaned up and added coverage to autopilot liquid stake and forward unit tests.

Brief Changelog

  • Slimmed down mocked state to only what's necessary
  • Added coverage to all error cases (by testing inner TryLiquidStake function instead of OnRecvPacket)
  • Improved error messages

@sampocs sampocs marked this pull request as ready for review January 3, 2024 00:20
This was referenced Jan 3, 2024
Merged
Merged
asalzmann
asalzmann approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes all lgtm - thanks for significantly cleaning up x/autopilot/keeper/liquidstake_test.go !

@sampocs sampocs merged commit 299f585 into sam/autopilot-fallback-address Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzmann asalzmann asalzmann approved these changes

@shellvish shellvish Awaiting requested review from shellvish

@riley-stride riley-stride Awaiting requested review from riley-stride

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @asalzmann