Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send disable tokenization tx for delegation account on hub #1045

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

ethan-stride
Copy link
Contributor

Runs the disable tokenization ICA tx for the delegation ICA on the hub
Should prevent fast and large withdrawal attempts using tokenization

Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far! Couple small comments and then needs the unit tests

proto/stride/stakeibc/ica_account.proto Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
@ethan-stride
Copy link
Contributor Author

LGTM thanks for figuring out the unit test

@sampocs sampocs added the v17 label Jan 9, 2024
@riley-stride
Copy link
Contributor

Has this been tested on Dockernet?

Copy link
Contributor

@riley-stride riley-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be tested on dockernet. otherwise lgtm

@sampocs sampocs merged commit f65bae9 into v17-upgrade-handler Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants