fixing init_chain script to not clobber new params #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are new params when starting the chain which were being overwritten
experimental_max_gossip_connections_to_persistent_peers
experimental_max_gossip_connections_to_non_persistent_peers
Because in the init_chain.sh script we had a regex looking for the variable persistent_peers and it was writing values to these
With the wrong type being written to these params, nodes after the first one would fail to start
This was causing dockernet to only start one validator when expecting 3 and then no blocks could reach consensus
Added a word boundary to that intended variable so these new variables can be left alone.
Dockernet can now start
All unit tests in
make test-unit
are passing againAll integration tests in
make test-integration-docker
are passing again