Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing init_chain script to not clobber new params #1139

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

ethan-stride
Copy link
Contributor

@ethan-stride ethan-stride commented Mar 15, 2024

There are new params when starting the chain which were being overwritten
experimental_max_gossip_connections_to_persistent_peers
experimental_max_gossip_connections_to_non_persistent_peers
Because in the init_chain.sh script we had a regex looking for the variable persistent_peers and it was writing values to these
With the wrong type being written to these params, nodes after the first one would fail to start
This was causing dockernet to only start one validator when expecting 3 and then no blocks could reach consensus

Added a word boundary to that intended variable so these new variables can be left alone.

Dockernet can now start
All unit tests in make test-unit are passing again
All integration tests in make test-integration-docker are passing again

Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

dockernet/src/init_chain.sh Outdated Show resolved Hide resolved
@sampocs sampocs merged commit e1408d1 into main Mar 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants