rebate integration tests #1152
Merged
rebate integration tests #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampocs
force-pushed
the
dydx-rebate/ig-tests
branch
from
13a1e65
to
6a16f0e
Compare
riley-stride
approved these changes
Mar 21, 2024
asalzmann
approved these changes
Mar 21, 2024
| @@ -67,7 +67,7 @@ func WithdrawalRewardBalanceCallback(k Keeper, ctx sdk.Context, args []byte, que | |||
|
|
|||
| // If there's a rebate portion, fund the community pool with that amount | |||
| if rebateAmount.GT(sdkmath.ZeroInt()) { | |||
| rebateToken := sdk.NewCoin(tradeRouteCallback.RewardDenom, rebateAmount) | |||
| rebateToken := sdk.NewCoin(tradeRoute.RewardDenomOnHostZone, rebateAmount) | |||
There was a problem hiding this comment.
I think these are actually the same thing if you look at how it sets RewardDenom before the call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Setup integration test scripts for rebate testing. There were also a few small bugs fixed in this process.
See
dockernet/scripts/community-pool-staking/README.mdChain Changes
Off-chain Changes
rebate.shscript to register a rebatetrade.shscript to execute authz trade