Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staketia migration - disable staketia LS #1213

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Jun 4, 2024

During the stTIA migration, liquid stakes are disabled from staketia and will be handled in stakeibc. This PR removes the LiquidStake functionality from staketia

@sampocs sampocs changed the base branch from main to staketia-migration June 4, 2024 22:42
@sampocs sampocs marked this pull request as ready for review June 7, 2024 00:27
@sampocs sampocs merged commit cb0f7e7 into staketia-migration Jun 7, 2024
1 check passed
Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for doing this!

x/staketia/keeper/msg_server.go Show resolved Hide resolved
@riley-stride
Copy link
Contributor

Should we also pull LiquidStake out of:

  • msgs.go
  • msgs_test.go
    A few other files, I see some mentions we could prob clean up when searching "LiquidStake" in x/staketia

@riley-stride
Copy link
Contributor

Otherwise this lgtm!

@sampocs
Copy link
Collaborator Author

sampocs commented Jul 26, 2024

@riley-stride we definitely could remove them from msgs but I was trying to keep the changes to a minimum and I don't think there's any harm in keeping them there since we'll eventually deprecate the whole module!

@riley-stride
Copy link
Contributor

@riley-stride we definitely could remove them from msgs but I was trying to keep the changes to a minimum and I don't think there's any harm in keeping them there since we'll eventually deprecate the whole module!

Makes sense. Good point about deprecating the module. I'm signed off here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants