Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wasm light client #1224

Merged
merged 2 commits into from
Jun 24, 2024
Merged

added wasm light client #1224

merged 2 commits into from
Jun 24, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Jun 20, 2024

Context

Added wasm light client to integrate with union bridge.

Referenced the following during the integration:

Open Questions

  • The compatibility matrix doesn't list ibc v7.4 - I used commit 7ee2a2452b79d0bc8316dc622a1243afa058e8cb which is for v7.3
  • The client router is not in ibc v7 so I excluded the following lines from app.go
 clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
 wasmLightClientModule := wasm.NewLightClientModule(app.WasmClientKeeper)
 clientRouter.AddRoute(ibcwasmtypes.ModuleName, &wasmLightClientModule)

Brief Changelog

  • Added wasm client, sharing the same wasmVM as x/wasm
  • Added the store key
  • Added the client name to AllowedClients in the upgrade handler

@github-actions github-actions bot added C:app-wiring dependencies Pull requests that update a dependency file labels Jun 20, 2024
Copy link
Contributor

@assafmo assafmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, overall LGTM.

app/app.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@sampocs sampocs merged commit 28046fa into main Jun 24, 2024
10 checks passed
@sampocs sampocs deleted the add-ibcwasm branch June 24, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants