Add Makefile, bash scripts to test multiple nodes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| strided keys add validator3 --keyring-backend=test --home=$HOME/.strided/validator3 | ||
|
|
||
| # change staking denom to uosmo | ||
| cat $HOME/.strided/validator1/config/genesis.json | jq '.app_state["staking"]["params"]["bond_denom"]="uosmo"' > $HOME/.strided/validator1/config/tmp_genesis.json && mv $HOME/.strided/validator1/config/tmp_genesis.json $HOME/.strided/validator1/config/genesis.json |
There was a problem hiding this comment.
should this be STRD? does it matter for testing?
There was a problem hiding this comment.
Don't think it matters too much for testing but great catch, we should change this to STRD
| @@ -98,13 +96,13 @@ func (k msgServer) MintStAsset(ctx sdk.Context, sender sdk.AccAddress, amount in | |||
| // It will panic if the module account does not exist or is unauthorized. | |||
| sdkerror := k.bankKeeper.MintCoins(ctx, types.ModuleName, stCoins) | |||
| if sdkerror != nil { | |||
| k.Logger(ctx).Info("Failed to mint coins"); | |||
There was a problem hiding this comment.
were these breaking with semicolons at the end?
There was a problem hiding this comment.
I think this was a linter change
stride/app/app.go
Outdated
| _ servertypes.Application = (*App)(nil) | ||
| _ simapp.App = (*App)(nil) | ||
| _ servertypes.Application = (*StrideApp)(nil) | ||
| _ ibctesting.TestingApp = (*StrideApp)(nil) |
There was a problem hiding this comment.
why did we add this back?
…uccessfully from this commit
… helpers for make test (eg in epochs keeper test); use custom config in app/genesis.go
| benchmark \ | ||
| build-docker-osmosisdnode localnet-start localnet-stop \ | ||
| docker-single-node | ||
|
|
||
| test: |
There was a problem hiding this comment.
The makefile now has three "test" targets.
- The first and second define recipes which run all the tests in the packages within the ./x/ folder and unit tests (many of which fail, as expected, since we haven't written these yet; I'm holding these tests are placeholders for now)
- The second runs unit tests too through
test-unitdependency. This seems to run the same tests as the first recipe, but it breaks on error. I'm commenting this out for now to get things running since we wouldn't expect these unit tests to work, so we would not want to fail on them until we've written them properly. Added TODO(TEST-49) to write the unit tests properly. - It also tries to run a
test-builddependency which doesn't exist (?)
- The second runs unit tests too through
- The third runs script/simple_test.sh, which works after I made a tweak to reset blockchain state (added the
--reset-onceflag
Is your intention to run the tests in each folder of the project or to run simple_test.sh? @asalzmann
- commented out test-unit in Makefile (we haeven't written unit tests yet!) - added blockchain reset arg to scripts/simple_test.sh
|
Some notes from fiddling with this: Issue 1: Validator 1 was silently dying after launching it on line 112
Same issue was occurring between runs because the old tmux processes were still running. An easy way to fix:
Helpful bash commands:
|
run "sh scripts/init.sh" to build working images to run 1 chain with 3 different nodes
|
let's go |
asalzmann
pushed a commit
that referenced
this pull request
Jan 25, 2024
added staketia to middleware stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Makefile, scripts to run multiple nodes. Before testing ICA / ICQ, we'll need scripts to bootstrap validator nodes and send calls between them.
This is pulled from the Osmosis repo.
It doesn't quite work yet, possible we need to reconfigure something with docker
Test plan
make buildandmake test