Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 upgrade #398

Closed
wants to merge 6 commits into from
Closed

v4 upgrade #398

wants to merge 6 commits into from

Conversation

asalzmann
Copy link
Contributor

@asalzmann asalzmann commented Nov 27, 2022

Co-authored-by: Hieu Vu 72878483+hieuvubk@users.noreply.github.com
Co-authored-by: Jacob Gadikian jacobgadikian@gmail.com

Closes: #384

Context and purpose of the change

As part of the v3 upgrade, we added authz. However, we forgot to set the store key as part of the upgrade. As a consequence, after the upgrade, validators that attempted to prune had apphash errors. More details from @chillyvee here.

Brief Changelog

  • Add upgrade_tests to the v3 / v4 upgrade
  • Initialize the params store for the claim and authz modules
  • Add v4 upgrade handler and set the authzkeeper.StoreKey

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

asalzmann and others added 5 commits November 25, 2022 18:55
Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>
Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>
@asalzmann asalzmann marked this pull request as ready for review November 27, 2022 22:05
@asalzmann asalzmann changed the title Hieu/upgrade handler (#397) v4 upgrade Nov 27, 2022
@mergify mergify bot mentioned this pull request Nov 27, 2022
@asalzmann asalzmann closed this Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants