-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 121 "combine": move records logic into the records module #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is included but broken
…e_ibc.go:OnAcknowledgementPacket
asalzmann
added a commit
that referenced
this pull request
Jan 25, 2024
Co-authored-by: vish-stride <vishal@stridelabs.co> Co-authored-by: shellvish <104537253+shellvish@users.noreply.github.com> Co-authored-by: Aidan Salzmann <aidan@stridelabs.co> Co-authored-by: Riley Edmunds <riley@stridelabs.co> Co-authored-by: riley-stride <104941670+riley-stride@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move records logic into
x/records
and add that records module keeper to the stakeibc module so records can be created from stakeibc.Details
msg_server_liquid_stake.go
andepochs.go
, adjust record-related logic to use the recordKeeper's record fnsTest plan
Run a local build, then execute
sh ./scripts-local/tests/1.sh
andsh ./scripts-local/tests/2.sh
. If you watch theaccounts.log
logs, you should see a depositRecord created as liquidstake is executed.