Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 121 "combine": move records logic into the records module #53

Merged
merged 42 commits into from
Jun 26, 2022

Conversation

riley-stride
Copy link
Contributor

Summary

Move records logic into x/records and add that records module keeper to the stakeibc module so records can be created from stakeibc.

Details

  • Manually move all record-related messages, protos etc. from stakeibc to records module
  • Add the records keeper in app.go and instantiate it before stakeibc's keeper; pass recordskeeper into stakeibc's keeper
  • In msg_server_liquid_stake.go and epochs.go, adjust record-related logic to use the recordKeeper's record fns
  • Add some draft logic to records/module_ibc.go's OnAcknowledgementPacket. Currently commented out until we merge in TEST46

Test plan

Run a local build, then execute sh ./scripts-local/tests/1.sh and sh ./scripts-local/tests/2.sh. If you watch the accounts.log logs, you should see a depositRecord created as liquidstake is executed.

@riley-stride riley-stride marked this pull request as ready for review June 26, 2022 04:28
@riley-stride riley-stride merged commit 530be4f into main Jun 26, 2022
riley-stride pushed a commit that referenced this pull request Sep 5, 2022
asalzmann added a commit that referenced this pull request Jan 25, 2024
Co-authored-by: vish-stride <vishal@stridelabs.co>
Co-authored-by: shellvish <104537253+shellvish@users.noreply.github.com>
Co-authored-by: Aidan Salzmann <aidan@stridelabs.co>
Co-authored-by: Riley Edmunds <riley@stridelabs.co>
Co-authored-by: riley-stride <104941670+riley-stride@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants