-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized Testnet #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me overall! was very helpful to walk through this yesterday. i'll start testing off of this now, and i'm sure we'll change some things, but I think this is good to merge now, as it's a huge improvement from the existing testnet infra
@@ -0,0 +1,36 @@ | |||
# Stride Node Setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent readme
@@ -0,0 +1,71 @@ | |||
{ | |||
"version": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if we need to check in tfstate or if terraform state pull
suffices? no problem at all with checking it in, just wondering what happens if two people run terraform commands without checking it in (could we end up in a bad state?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great question. Honestly, I think the best practice would be to store the state using a terraform cloud account. It's free and pretty easy to setup.And to the second question, I think it will error out if we try and run a command from an outdated state - not positive though.
One thing to talk through today might be how we separate out different deployments. I'm hoping just the variable change acts as the equivalent of having a main.tf
if an entirely different file (in that it treats them as separate terraform modules/resources) - but definitely something to double check
$st_cmd init $moniker --chain-id $CHAIN_NAME --overwrite 2> /dev/null | ||
|
||
# Update node networking configuration | ||
sed -i -E "s|cors_allowed_origins = \[\]|cors_allowed_origins = [\"\*\"]|g" "${STATE}/${node_name}/config/config.toml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good flag on this yesterday, will see if we can restrict this to only stridenet.co
Update validator.network seed node addresses
Summary
Test plan