Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix claim bug #70
Fix claim bug #70
Changes from all commits
a7edc92
416dde9
e82725c
5cd377a
411621a
577ef63
ca71746
6d5da1b
345cd55
e4e71b0
b5c6c99
e5a92be
90f91b6
cd80748
a1718e6
ffdb5ed
8936174
cdd8fcb
6579d93
21e569a
c4aa661
6480a0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is whitelist address ?
If this is what it need in advance. it would be better on the params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, at least, this address should exist as a parameter in the module.
so that it must be changed only by governance proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! This is an admin account that's here for testnet purposes, good point about parameters. We appreciate the reviews, please keep them coming! By the way, if you want to get in touch please DM us on Discord, we'd love to chat more 👍