reward converter - remove cache context wrapper and add trade route callback #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback Keys Context
Instead of passing the trade route to the callback data, we should just pass the keys and re-look it up in the callback itself.
Main reason is to avoid a case where we accidentally override an updated route with a stale value. I don't think we currently re-set a TradeRoute in any of our callbacks, but I could see us doing this in the future and not remembering this scenario. Additionally, it could cause us to use a stale price as follows:
Removing Cache Wrapper Context
After discussing offline, we decided the cache context wrapper is no longer needed and that we can return errors instead.
The main reasons to use the wrapper are if:
The examples here have neither of these cases, so we can just throw an error. But we should test these cases in dockernet to be sure.