Fixed Bulk Add DatumAlreadyExistsError and AnnotationAlreadyExistsError
#643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
ntlind
reviewed
Jul 2, 2024
client/valor/client.py
Outdated
| @@ -192,10 +192,9 @@ def _requests_wrapper( | |||
| method_name: str, | |||
| endpoint: str, | |||
| ignore_auth: bool = False, | |||
| max_retries_on_timeout=2, | |||
| initial_timeout: float = 2, | |||
| timeout: Optional[float] = 2, | |||
There was a problem hiding this comment.
this is one of the reasons you'll see people use 0 or -1 to mean "don't use a timeout" instead of None
ntlind
reviewed
Jul 2, 2024
client/valor/coretypes.py
Outdated
| @@ -1458,6 +1471,7 @@ def create_predictions( | |||
| dataset: Dataset, | |||
| model: Model, | |||
| predictions: List[Prediction], | |||
| timeout: Optional[float] = None, | |||
There was a problem hiding this comment.
I didnt make the retry logic configurable, retrying for POST requests is completely removed.
take create_groundtruths: how is retrying for POST requests completely removed if the user can configure them with a timeout param?
ntlind
reviewed
Jul 2, 2024
ntlind
approved these changes
Jul 3, 2024
ntlind
approved these changes
Jul 3, 2024
Co-authored-by: Nick L <nthorlind@gmail.com>
…39-bug-bulk-add-error
ekorman
approved these changes
Jul 3, 2024
ekorman
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The default timeout was 10s for all requests in the python client. For most requests this is fine, but for bulk add where a large JSON payload would have to be parsed by the API this would cause an early timeout.
This would have been caught earlier but the python client would perform automatic retrying of the POST request. This would immediately cause a conflict on the API-side as the already existing data was being uploaded.
Example
The following shows the same request being resent without the knowledge of the user. The "retry" immediately fails because it directly conflicts with the original request.
Solution