Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed confusion matrix components. #825

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Renamed confusion matrix components. #825

merged 2 commits into from
Dec 5, 2024

Conversation

czaloom
Copy link
Collaborator

@czaloom czaloom commented Dec 5, 2024

Renamed

  • hallucinations to unmatched_predictions
  • missing_predictions to unmatched_ground_truths

@czaloom czaloom linked an issue Dec 5, 2024 that may be closed by this pull request
ENH: Rename attributes within ConfusionMatrix metric. #807
Closed
3 tasks
@czaloom czaloom self-assigned this Dec 5, 2024
@czaloom czaloom marked this pull request as ready for review December 5, 2024 17:11
rsbowman-striveworks
rsbowman-striveworks approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rsbowman-striveworks rsbowman-striveworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this will require some changes to the Chariot repo when we upgrade Valor there.

@czaloom czaloom merged commit 6baaba2 into main Dec 5, 2024
14 checks passed
@czaloom czaloom deleted the czaloom-807-rename-cm-attributes branch December 5, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsbowman-striveworks rsbowman-striveworks rsbowman-striveworks approved these changes

@ekorman ekorman Awaiting requested review from ekorman ekorman is a code owner

@jyono jyono Awaiting requested review from jyono jyono is a code owner

Assignees

@czaloom czaloom

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Rename attributes within ConfusionMatrix metric.
2 participants
@czaloom @rsbowman-striveworks