Skip to content
This repository has been archived by the owner on May 19, 2024. It is now read-only.

[WEAV-16] ๐Ÿ”ง SonarCloud ๊ด€๋ จ ์„ค์ • #3

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Jan 18, 2024

Sonar Cloud ๊ด€๋ จ ์„ค์ •์ด์—์š”
main ๋ธŒ๋ Œ์น˜์— ๋Œ€ํ•ด pr์‹œ ๋™์ž‘ํ•ด์š”

@waterfogSW waterfogSW added the config Configuration Setting label Jan 18, 2024
@waterfogSW waterfogSW self-assigned this Jan 18, 2024
@waterfogSW waterfogSW marked this pull request as draft January 18, 2024 02:16
dojinyou
dojinyou previously approved these changes Jan 18, 2024
.github/workflows/sonar_cloud.yaml Outdated Show resolved Hide resolved
Comment on lines +27 to +31
- name: Cache Gradle packages
uses: actions/cache@v3
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4; open jdk์—์„œ ์…‹์—…ํ•  ๋•Œ gradle ์บ์‹œ๊นŒ์ง€ ์ฒ˜๋ฆฌํ•ด๋„ ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™์•„์š”!

https://github.com/actions/setup-java#caching-gradle-dependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ๋Š” ์บ์‹œ์ฒ˜๋ฆฌ๋˜์–ด์žˆ๋Š”๊ฑฐ ๊ฐ™์€๋ฐ, ์–ด๋–ค๊ฑฐ ๋ง์”€์ด์‹ ๊ฑด์ง€ ์ข€๋” ์„ค๋ช… ๋ถ€ํƒ๋“œ๋ ค๋„ ๋ ๊นŒ์šฉ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณ„๋„๋กœ ๊ทธ๋ž˜๋“ค ์บ์‹œ ์“ฐ์ง€๋ง๊ตฌ jdk ์…‹์—…ํ•  ๋•Œ ์ง€์›ํ•˜๋Š”๊ฑฐ ์“ฐ์ž๋Š” ์˜๋ฏธ์˜€์–ด์šฉ!
๊ฐ™์€ ๊ฑฐ ๊ฐ™์•„์„œ?

@waterfogSW waterfogSW force-pushed the feat/WEAV-16 branch 2 times, most recently from 0c90b71 to 4882c8d Compare January 19, 2024 03:52
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required โ‰ฅ 80%)

See analysis details on SonarCloud

@waterfogSW
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required โ‰ฅ 80%)

See analysis details on SonarCloud

Sonar cloud ๊ธฐ๋ณธ์„ธํŒ…์ด ์ปค๋ฒ„๋ฆฌ์ง€ 80%๋„ค์š”, ์ง€๊ธˆ์€ ์ฝ”๋“œ๊ฐ€ ์—†์–ด์„œ 0%๋กœ fail๋œจ๋Š”๋ฐ ์ผ๋‹จ mergeํ•˜๊ณ  ์œ ์ง€ํ• ๊นŒ์š”? ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋‚˜์˜ฌ๋•Œ๊นŒ์ง€๋Š” ๊ณ„์† fail๋กœ ๊ฐˆ๊ฒƒ๊ฐ™์•„์š”

@waterfogSW waterfogSW marked this pull request as ready for review January 19, 2024 07:36
@dojinyou
Copy link
Collaborator

dojinyou commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required โ‰ฅ 80%)
See analysis details on SonarCloud

Sonar cloud ๊ธฐ๋ณธ์„ธํŒ…์ด ์ปค๋ฒ„๋ฆฌ์ง€ 80%๋„ค์š”, ์ง€๊ธˆ์€ ์ฝ”๋“œ๊ฐ€ ์—†์–ด์„œ 0%๋กœ fail๋œจ๋Š”๋ฐ ์ผ๋‹จ mergeํ•˜๊ณ  ์œ ์ง€ํ• ๊นŒ์š”? ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋‚˜์˜ฌ๋•Œ๊นŒ์ง€๋Š” ๊ณ„์† fail๋กœ ๊ฐˆ๊ฒƒ๊ฐ™์•„์š”

๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์€ 70์ด๋‚˜ 65๊นŒ์ง€ ๋‚ด๋ ค๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”! ์ปค๋ฒ„๋ฆฌ์ง€๊ฐ€ ํฌ๊ฒŒ ์ค‘์š”ํ•˜๋‹ค๊ณ  ์ƒ๊ฐํ•˜์ง€๋Š” ์•Š์•„์„œ?
์•„์˜ˆ ์ฐธ๊ณ ์šฉ์œผ๋กœ๋งŒ ์จ๋„ ๊ดœ์ฐฎ๊ตฌ์š”. ์ปค๋ฒ„๋ฆฌ์ง€ ์ธก์ •๋„ ๋ถ„๊ธฐ๋ฌธ ๋‹จ์œ„๋กœ ํ•˜๋ฉด ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™๊ตฌ์š”!

Copy link
Collaborator

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์บ์‹œ ๊ด€๋ จ์€ ๋งˆ์ด๋„ˆ ์ฝ”๋ฉ˜ํŠธ๋ผ ๋„˜๊ธฐ์…”๋„ ๋ผ์š” :) ๐Ÿ’ฏ

@waterfogSW
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required โ‰ฅ 80%)
See analysis details on SonarCloud

Sonar cloud ๊ธฐ๋ณธ์„ธํŒ…์ด ์ปค๋ฒ„๋ฆฌ์ง€ 80%๋„ค์š”, ์ง€๊ธˆ์€ ์ฝ”๋“œ๊ฐ€ ์—†์–ด์„œ 0%๋กœ fail๋œจ๋Š”๋ฐ ์ผ๋‹จ mergeํ•˜๊ณ  ์œ ์ง€ํ• ๊นŒ์š”? ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋‚˜์˜ฌ๋•Œ๊นŒ์ง€๋Š” ๊ณ„์† fail๋กœ ๊ฐˆ๊ฒƒ๊ฐ™์•„์š”

๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์€ 70์ด๋‚˜ 65๊นŒ์ง€ ๋‚ด๋ ค๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”! ์ปค๋ฒ„๋ฆฌ์ง€๊ฐ€ ํฌ๊ฒŒ ์ค‘์š”ํ•˜๋‹ค๊ณ  ์ƒ๊ฐํ•˜์ง€๋Š” ์•Š์•„์„œ? ์•„์˜ˆ ์ฐธ๊ณ ์šฉ์œผ๋กœ๋งŒ ์จ๋„ ๊ดœ์ฐฎ๊ตฌ์š”. ์ปค๋ฒ„๋ฆฌ์ง€ ์ธก์ •๋„ ๋ถ„๊ธฐ๋ฌธ ๋‹จ์œ„๋กœ ํ•˜๋ฉด ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™๊ตฌ์š”!

์ข‹์Šต๋‹ˆ๋‹ค. ๋ถ„๊ธฐ๋ฌธ๋‹จ์œ„, 70%๋กœ ๋งž์ถฐ์„œ ์„ธํŒ…ํ•ด๋‘˜๊ฒŒ์š” ๐Ÿ‘

@waterfogSW waterfogSW merged commit 30fba82 into main Jan 19, 2024
2 of 3 checks passed
@waterfogSW waterfogSW deleted the feat/WEAV-16 branch January 19, 2024 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config Configuration Setting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants