-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file found but asBinary reads beyond range in nodejs #126
Comments
I can reproduce the issue, it comes from pako's inflateRaw. I've opened an issue on their side (nodeca/pako#22) |
jszip 2.2.1 switched underlying zlib engines. The new engine is broken. (h/t @shawnpresser) See: - Stuk/jszip#126 - nodeca/pako#22
@dduponchel a change like this (from zlibjs to pako) deserves at least a minor version bump (to 2.3.0), possibly a major version bump (3.0.0) |
Releasing it as a v2.2.1 was clearly a stupid idea and I apologize for that. Everyone with a dependency on Now, we have a v2.2.2 which should have been a v2.3.1. To go to that state, we would need to revert the zlib.js -> pako migration (and get back the v2.2.0 bug), release it as v2.2.3 and revert the revert to get a v2.3.0. I honestly don't know if a v2.3.0 release now is a good or a bad idea. |
@dduponchel it was my mistake to use |
The
I will ! |
jszip 2.2.1 switched underlying zlib engines. The new engine is broken. (h/t @shawnpresser) See: - Stuk/jszip#126 - nodeca/pako#22
jszip 2.2.1 switched underlying zlib engines. The new engine is broken. (h/t @shawnpresser) See: - Stuk/jszip#126 - nodeca/pako#22
https://www.dropbox.com/s/w2hwdzfax6ci70y/apachepoi_46535.xlsx
The subfile 'xl/worksheets/sheet4.xml' exists and jszip confirms:
However, trying to read the file using
.asBinary()
throws an error:Note that this works using jszip@2.2.0 (which uses zlibjs)
The text was updated successfully, but these errors were encountered: