Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jszip to bower (seems like you would just need a component.json) #19

Closed
redchair123 opened this issue Dec 2, 2012 · 6 comments
Closed

Comments

@redchair123
Copy link

bower: https://github.com/twitter/bower
bower repository: http://sindresorhus.com/bower-components/

@dduponchel
Copy link
Collaborator

Bower looks great, it is a good idea, but :

  • it is not the only dependency manager. Component also uses the component.json file and they are not fully compatible (see bower#39 or the comments in bower#110).
  • we lack a build phase between the commited code and the pulled code. The bower doc says There should only be at most one file per file type in the main list.. That means concatenate(/minify) the js files and commit the result for each commit.
  • JSZip has no version :-)

A solution for the first 2 points is to create a jszip-bower repository (like angular) with a component.json and minified/concatened files, one commit per release of JSZip. We could also try a jszip-release repository with component.json/package.json for bower/component/ender/jam/volo/... but I don't know if that will work.

@ravenac95
Copy link

If either of you were at all interested. I took it upon myself to add jszip to bower's component repo. I agree with @dduponchel assessment so I created a jszip-bower repository that includes a minified jszip as well as the unminified jszip files if the user wished to use those instead. I do think we should track versions in JSZip and I'm going to add an issue for it.

Here's the link to the jszip-bower repository: https://github.com/ravenac95/jszip-bower

If any of the original authors would like me to remove this from the bower repo so that JSZip bower can be handled "in house," I would be absolutely willing.

@dduponchel
Copy link
Collaborator

Thanks for the jszip package !

@sorich87
Copy link

I think this should be reconsidered.

@ravenac95's repository is not up to date. @dduponchel, I think it's better to simply register this repository with Bower instead of a separate one for the following reasons:

  • Bower uses bower.json now and there's no conflict with Component anymore.
  • If you don't want to add a bower.json file, it won't be a problem either since the JSZip doesn't have any dependencies. It will work without a bower.json file.
  • Bower is mostly used with Yeoman and/or Grunt which do the minification so you don't need to include minified files in this repository.
  • JSZip now has versions.

@ravenac95
Copy link

@sorich87 is probably right. I've been remiss in updating for a long while as I've transitioned to using component and personal duties have prevented me from keeping up. I can transfer ownership to anyone who'd like to take up the mantel if keeping a separate repo is still the preferred method.

I will, however, update right now.

@dduponchel
Copy link
Collaborator

@sorich87 I think you are right, I reopen the issue ! I will just wait for #74 which will change a lot of things (it splits JSZip into smaller files and adds a build phase).

@ravenac95 thanks again for the repository !

@dduponchel dduponchel reopened this Oct 30, 2013
calvinmetcalf pushed a commit to calvinmetcalf/jszip that referenced this issue Nov 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants