-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jszip to bower (seems like you would just need a component.json) #19
Comments
Bower looks great, it is a good idea, but :
A solution for the first 2 points is to create a jszip-bower repository (like angular) with a component.json and minified/concatened files, one commit per release of JSZip. We could also try a jszip-release repository with component.json/package.json for bower/component/ender/jam/volo/... but I don't know if that will work. |
If either of you were at all interested. I took it upon myself to add jszip to bower's component repo. I agree with @dduponchel assessment so I created a jszip-bower repository that includes a minified jszip as well as the unminified jszip files if the user wished to use those instead. I do think we should track versions in JSZip and I'm going to add an issue for it. Here's the link to the jszip-bower repository: https://github.com/ravenac95/jszip-bower If any of the original authors would like me to remove this from the bower repo so that JSZip bower can be handled "in house," I would be absolutely willing. |
Thanks for the jszip package ! |
I think this should be reconsidered. @ravenac95's repository is not up to date. @dduponchel, I think it's better to simply register this repository with Bower instead of a separate one for the following reasons:
|
@sorich87 is probably right. I've been remiss in updating for a long while as I've transitioned to using component and personal duties have prevented me from keeping up. I can transfer ownership to anyone who'd like to take up the mantel if keeping a separate repo is still the preferred method. I will, however, update right now. |
@sorich87 I think you are right, I reopen the issue ! I will just wait for #74 which will change a lot of things (it splits JSZip into smaller files and adds a build phase). @ravenac95 thanks again for the repository ! |
bower: https://github.com/twitter/bower
bower repository: http://sindresorhus.com/bower-components/
The text was updated successfully, but these errors were encountered: