Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade zlibjs to version 0.2.0, fix #104 #105

Merged
merged 1 commit into from
Feb 24, 2014
Merged

upgrade zlibjs to version 0.2.0, fix #104 #105

merged 1 commit into from
Feb 24, 2014

Conversation

Mithgol
Copy link
Contributor

@Mithgol Mithgol commented Feb 24, 2014

We are starting to use a newer zlibjs package.

Resolves #104.

@dduponchel
Copy link
Collaborator

Thanks @Mithgol !
This also fixes #97.

dduponchel added a commit that referenced this pull request Feb 24, 2014
upgrade zlibjs to version 0.2.0, fix #104
@dduponchel dduponchel merged commit 59a0262 into Stuk:master Feb 24, 2014
@Mithgol
Copy link
Contributor Author

Mithgol commented Feb 24, 2014

@Stuk

Good luck with publishing a new version of your npm package.

@dduponchel
Copy link
Collaborator

I agree with a new release because zlibjs went from 0.1.7 to 0.2.0 so the tilde operator in our package.json won't use the new version. But I don't know if we should go for a 2.1.2 (without #93) to take advantage of the tilde operator (the default with npm install --save) or release master with a 2.2.0 (with #93).
Any thoughts ?

@Stuk
Copy link
Owner

Stuk commented Feb 25, 2014

I would vote 2.2.0 with #93. #93 is very unlikely to break anything for anyone, so it's an easy upgrade for users.

@dduponchel
Copy link
Collaborator

See #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zlibjs version 0.1.7 is too big
3 participants