Update permissions #205
Merged
Update permissions #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From "UNIX, version 2.0" to "UNIX, version 3.0". This is the value used by info-zip, ark and file-roller (on xubuntu). The others I tested file-roller (on ubuntu) and 7z uses "UNIX, version 6.3". Using "3.0" seems to be a safe bet.
This is an update for Stuk#200. If we don't keep the original unix/dos permissions, this will lead to hard-to-debug issues, where the permissions are not exactly like they were specified. This commit changes that and uses the exact file mode. It also updates the default umask from 022 to 002 (with unixPermissions == null, files will get 0664 and folders 0775). To put a folder with custom permissions, folder() is not a good candidate : its behavior is to re-use existing entries. Instead, this commit documents the existing dir attribute.
|
Looks great! I'm waiting for this feature to be landed =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update for #200.
If we don't keep the original unix/dos permissions, this will lead to
hard-to-debug issues, where the permissions are not exactly like they
were specified.
This pull request changes that and uses the exact file mode. It also updates the
default umask from 022 to 002 (with unixPermissions == null, files will
get 0664 and folders 0775).
To put a folder with custom permissions, folder() is not a good
candidate : its behavior is to re-use existing entries. Instead, this
commit documents the existing dir attribute.
This pull request also updates the field "version made by" for UNIX
from "UNIX, version 2.0" to "UNIX, version 3.0".