Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions #205

Merged
merged 2 commits into from
Mar 10, 2015
Merged

Update permissions #205

merged 2 commits into from
Mar 10, 2015

Conversation

dduponchel
Copy link
Collaborator

This is an update for #200.

If we don't keep the original unix/dos permissions, this will lead to
hard-to-debug issues, where the permissions are not exactly like they
were specified.
This pull request changes that and uses the exact file mode. It also updates the
default umask from 022 to 002 (with unixPermissions == null, files will
get 0664 and folders 0775).

To put a folder with custom permissions, folder() is not a good
candidate : its behavior is to re-use existing entries. Instead, this
commit documents the existing dir attribute.

This pull request also updates the field "version made by" for UNIX
from "UNIX, version 2.0" to "UNIX, version 3.0".

From "UNIX, version 2.0" to "UNIX, version 3.0". This is the value used
by info-zip, ark and file-roller (on xubuntu). The others I tested
file-roller (on ubuntu) and 7z uses "UNIX, version 6.3".

Using "3.0" seems to be a safe bet.
This is an update for Stuk#200.

If we don't keep the original unix/dos permissions, this will lead to
hard-to-debug issues, where the permissions are not exactly like they
were specified.
This commit changes that and uses the exact file mode. It also updates the
default umask from 022 to 002 (with unixPermissions == null, files will
get 0664 and folders 0775).

To put a folder with custom permissions, folder() is not a good
candidate : its behavior is to re-use existing entries. Instead, this
commit documents the existing dir attribute.
@rickychien
Copy link

Looks great! I'm waiting for this feature to be landed =)

Stuk added a commit that referenced this pull request Mar 10, 2015
@Stuk Stuk merged commit e930e39 into Stuk:master Mar 10, 2015
@dduponchel dduponchel mentioned this pull request Mar 10, 2015
@dduponchel dduponchel deleted the update_permissions branch March 24, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants