Improve encoding support #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some archive managers use the machine encoding to generate the file name and comment. The user can recover the content of a file not encoded in UTF-8 but can't do anything for the file name. This new option adds the ability to decode file names and comments with a custom algorithm. See Stuk#210.
This option allows the user to generate a zip file with a custom encoding for the entry file name / comment. See also "decodeFileName" in load(). Not using UTF-8 when generating a zip file is maybe asking for troubles but some archive managers (Windows Compressed Folders for example) don't support well unicode stuff. See Stuk#210.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds decodeFileName in load() and encodeFileName in generate(). These options allow to read / generate zip files with non-UTF-8 file names / comments (Windows Compressed Folders doesn't seem to support UTF-8 entries for example).
Fix #210