Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove es.js & replace it by .mjs #119

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

Stun3R
Copy link
Owner

@Stun3R Stun3R commented Jan 17, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

It seems that for some people the es.js extension doesn't work & the package is not recognised as an ES module

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for strapi-sdk-js canceled.

🔨 Explore the source changes: 16106d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/strapi-sdk-js/deploys/61e5c0addac67d0008acb0c2

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #119 (16106d8) into main (0c6ed77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          106       106           
  Branches        18        18           
=========================================
  Hits           106       106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6ed77...16106d8. Read the comment docs.

@Stun3R Stun3R merged commit 3cae2ac into main Jan 17, 2022
@Stun3R Stun3R deleted the build/mjs-compatibility branch February 16, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant