Fetch .regal.json capabilites files for Enterprise OPA #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon, as part of the Enterprise OPA release process, complete built-ins data will be pushed to the public repo. This will allow Regal to generate rich hover messages and show the correct links to documentation of additional built-ins. Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
approved these changes
Nov 5, 2024
srenatus
reviewed
Nov 5, 2024
| @@ -287,7 +287,7 @@ fetch_eopa_caps if { | |||
| not eopa_caps_tree[p] | |||
|
|
|||
| # construct the URL to fetch the content from | |||
| r := rq.template("https://raw.githubusercontent.com/StyraInc/enterprise-opa/main/capabilities/{{.tag}}.json", {"tag": t}) | |||
| r := rq.template("https://raw.githubusercontent.com/StyraInc/enterprise-opa/main/capabilities/{{.tag}}.regal.json", {"tag": t}) | |||
There was a problem hiding this comment.
This will fail for old tags, iirc
There was a problem hiding this comment.
It should not have, since the test to fetch an old tag is based on the file on disk which is renamed to the format as before. However, sounds like we won't be needing now!
|
Closing as no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon, as part of the Enterprise OPA release process, complete built-ins data will be pushed to the public repo. This will allow Regal to generate rich hover messages and show the correct links to documentation of additional built-ins.