Use new setting to cache AST conversions from store #1256
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Nov 12, 2024
anderseknert
force-pushed
the
store-read-ast
branch
from
0fbe57e
to
45b4f0f
Compare
This doesn't have a huge impact on `regal lint` (although it does result in less allocations), but could potentially make a real difference for the LSP policies where ASTs from the whole workspace is provided under `data.workspace`. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
store-read-ast
branch
from
45b4f0f
to
2a7b2aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have a huge impact on
regal lint(although it does result in less allocations), but could potentially make a real difference for the LSP policies where ASTs from the whole workspace is provided underdata.workspace.Also, add the simple benchmark test I've been using for OPA fixes.