Fix: Scaffolding now properly populates templatesge nam… #277
Conversation
cmd/new.go
Outdated
| } else { | ||
| tmplNameTestValue = "." + params.name + "_test" | ||
| tmplNameTestValue = "." + params.name + "-test" |
There was a problem hiding this comment.
This shouldn't change — the _test suffix is idiomatic for test packages.
There was a problem hiding this comment.
I ran "regal new rule -t custom -c test -n some_name" a few times, so it might have created it.
There was a problem hiding this comment.
But why doesn't it build correctly?
There was a problem hiding this comment.
Some rather strict linter rules for Go as well :P
There was a problem hiding this comment.
I ran "regal new rule -t custom -c test -n some_name" a few times, so it might have created it.
What I mean is — even if your linte rule would be called "foo-bar-baz", the idiomatic naming for its test package would be "foo-bar-baz_test". So the code should not rewrite that to be "foo-bar-baz-test".
There was a problem hiding this comment.
However, it still doesn't seem to build. I can't figure out why.
There was a problem hiding this comment.
The linter is complaining that we're not using the first assignment, i.e.
// This assignment is never used
tmplNameValue := strings.ReplaceAll(params.name, "_", "-")And it's correct about that. It was my code, so apologies for that! We should of course us it in the contains check:
tmplNameValue = strings.ReplaceAll(params.name, "_", "-")
if strings.Contains(tmplNameValue, "-") {Same thing for the test template name.
There was a problem hiding this comment.
Should be fixed now. Still doesn't build - a ton of "Cannot open: file exists" errors.
There was a problem hiding this comment.
Finally works - had to decuddle assignments (their linter sure is rough to get by) :)
There was a problem hiding this comment.
Hehe, sure is! Yeah, those warnings are annoying but nothing to worry about. Some bug in the Go linter as I understood it.
I'd suggest getting golangcilint yourself so that you can run golangci-lint run ./... yourself before pushing your commits.
ThomasKingoTM
force-pushed
the
scaffoldFix
branch
from
95c125b
to
2af28a0
Compare
…es, imports the correct path 'as rule' and pupulates 'title' correctly in test.
anderseknert
force-pushed
the
scaffoldFix
branch
from
8cd382f
to
53bf024
Compare
|
Thanks! |
* fix, scaffolding now populates the templates with correct package names, imports the correct path 'as rule' and pupulates 'title' correctly in test.
The scaffolding "regal new rule" was adding incorrectly formatted package names in both the regal policy and the test.
This PR should fix the following: