Ensure rule "name" logic works without rule.head.name #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name attribute is not present in ref-head rules, so make sure things keep working when those are around. Fixes #276 Note though that the rules don't yet necessarily take all ref names into account. Will look at that separately. Just fix the bug for now. Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
reviewed
Aug 30, 2023
| # true | ||
| # if true | ||
| # | ||
| # If you write Rego like that — you're not going to use Regal anyway, are you? ¯\_(ツ)_/¯ |
srenatus
approved these changes
Aug 30, 2023
Comment on lines
+31
to
+34
| _is_name(ref, pos) if { | ||
| pos == 0 | ||
| ref.type == "var" | ||
| } |
There was a problem hiding this comment.
[golf]
Suggested change
| _is_name(ref, pos) if { | |
| pos == 0 | |
| ref.type == "var" | |
| } | |
| _is_name(ref, 0) if ref.type == "var" |
There was a problem hiding this comment.
I like it :) And in this case it won't matter, but I remember how "pattern matching" on function args was noticeably slower when done in the hot path of walk traversals.
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
The name attribute is not present in ref-head rules, so make sure things keep working when those are around. Fixes StyraInc#276 Note though that the rules don't yet necessarily take all ref names into account. Will look at that separately. Just fix the bug for now. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name attribute is not present in ref-head rules, so make sure things keep working when those are around.
Fixes #276
Note though that the rules don't yet necessarily take all ref names into account. Will look at that separately. Just fix the bug for now.