bundle: rearrange embed.FS setup #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Aug 30, 2023
anderseknert
approved these changes
Aug 30, 2023
| // it's preferable to filter them out from the bundle than to e.g. create a separate directory for tests | ||
| // | ||
| //go:embed * | ||
| var Bundle embed.FS |
There was a problem hiding this comment.
Error: ST1022: comment on exported var Bundle should be of the form "Bundle ..." (stylecheck)
Adding an ignore on package level should be fine here.
srenatus
force-pushed
the
sr/rearrange-embeds
branch
from
0ba0c6f
to
72de5de
Compare
srenatus
commented
Aug 30, 2023
| @@ -94,7 +94,7 @@ func CloseFileIgnore(file *os.File) { | |||
| } | |||
|
|
|||
| func ExcludeTestFilter() filter.LoaderFilter { | |||
| return func(abspath string, info files.FileInfo, depth int) bool { | |||
| return func(_ string, info files.FileInfo, _ int) bool { | |||
There was a problem hiding this comment.
Sorry, unrelated change. I had just happened to look into how the bundle is loaded...
|
Tests fail, back to draft. I'm looking into it. |
No functional changes, I hope! Signed-off-by: Stephan Renatus <stephan@styra.com>
srenatus
force-pushed
the
sr/rearrange-embeds
branch
from
72de5de
to
88b0209
Compare
srenatus
added a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
No functional changes, I hope! Signed-off-by: Stephan Renatus <stephan@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, I hope!