fixes DataTable rendering in doscover (opensearch-project#5207)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe · Oct 7, 2023 · d771c26 · d771c26
1 parent 40dd4bd
commit d771c26
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/plugins/discover/public/application/view_components/canvas/discover_table.tsx b/src/plugins/discover/public/application/view_components/canvas/discover_table.tsx
@@ -16,15 +16,14 @@ import {
   useDispatch,
   useSelector,
 } from '../../utils/state_management';
-import { useSearch } from '../utils/use_search';
 import { IndexPatternField, opensearchFilters } from '../../../../../data/public';
 import { DocViewFilterFn } from '../../doc_views/doc_views_types';
 import { SortOrder } from '../../../saved_searches/types';
 import { DOC_HIDE_TIME_COLUMN_SETTING } from '../../../../common';
 import { OpenSearchSearchHit } from '../../doc_views/doc_views_types';
 
 interface Props {
-  rows: OpenSearchSearchHit[];
+  rows?: OpenSearchSearchHit[];
 }
 
 export const DiscoverTable = ({ rows }: Props) => {

diff --git a/src/plugins/discover/public/application/view_components/canvas/index.tsx b/src/plugins/discover/public/application/view_components/canvas/index.tsx
@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { useEffect, useState, useRef, useCallback, useMemo } from 'react';
+import React, { useEffect, useState, useRef, useCallback } from 'react';
 import { EuiPanel } from '@elastic/eui';
 import { TopNav } from './top_nav';
 import { ViewProps } from '../../../../../data_explorer/public';
@@ -89,9 +89,6 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
 
   const timeField = indexPattern?.timeFieldName ? indexPattern.timeFieldName : undefined;
 
-  const MemoizedDiscoverTable = React.memo(DiscoverTable);
-  const MemoizedDiscoverChartContainer = React.memo(DiscoverChartContainer);
-
   return (
     <EuiPanel
       hasBorder={false}
@@ -126,3 +123,6 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
     </EuiPanel>
   );
 }
+
+const MemoizedDiscoverTable = React.memo(DiscoverTable);
+const MemoizedDiscoverChartContainer = React.memo(DiscoverChartContainer);