Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store workspace id in hash #5

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

SuZhou-Joe
Copy link
Owner

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ruanyl and others added 21 commits October 7, 2023 15:11
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
* Discover: Fixes state persistence after nav
* Fixed breadcrumbs and navigation
* fixes mobile view

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e980fa) 66.78% compared to head (05fda74) 66.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   66.78%   66.79%   +0.01%     
==========================================
  Files        3284     3286       +2     
  Lines       63092    63126      +34     
  Branches    10048    10052       +4     
==========================================
+ Hits        42134    42164      +30     
- Misses      18486    18488       +2     
- Partials     2472     2474       +2     
Flag Coverage Δ
Linux_1 35.25% <26.66%> (-0.01%) ⬇️
Linux_2 55.29% <94.11%> (+0.05%) ⬆️
Linux_3 43.82% <26.66%> (-0.03%) ⬇️
Linux_4 35.35% <26.66%> (-0.01%) ⬇️
Windows_1 35.27% <26.66%> (-0.01%) ⬇️
Windows_2 55.26% <94.11%> (+0.05%) ⬆️
Windows_3 43.83% <26.66%> (-0.02%) ⬇️
Windows_4 35.35% <26.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lication/capabilities/capabilities_service.mock.ts 100.00% <ø> (ø)
src/core/public/core_system.test.mocks.ts 100.00% <100.00%> (ø)
src/core/public/core_system.ts 91.95% <100.00%> (+0.38%) ⬆️
src/core/public/mocks.ts 59.09% <ø> (ø)
src/core/public/plugins/plugin_context.ts 44.44% <ø> (ø)
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <100.00%> (ø)
...e/server/capabilities/capabilities_service.mock.ts 75.00% <ø> (ø)
...c/core/server/capabilities/capabilities_service.ts 100.00% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 88.88% <88.88%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants