Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Leading space in text after inline image, should be left untouched #217

Closed
ngaurav opened this issue Jan 16, 2020 · 6 comments
Closed
Assignees

Comments

@ngaurav
Copy link
Contributor

ngaurav commented Jan 16, 2020

Html(data: "<p>Text <img src=""/> Text2</p>
The space just before Text2 is not rendered.

@Sub6Resources
Copy link
Owner

You are correct. Are you on version 1.0.0?

@Sub6Resources Sub6Resources self-assigned this Jan 16, 2020
@ngaurav
Copy link
Contributor Author

ngaurav commented Jan 17, 2020

Yes I am on 1.0.0

The solution is to add the following code around line 408

if (tree is ImageContentElement || tree is SvgContentElement) {
wpc.data = false;
}

@Nijinsha
Copy link

Any update on this?

@Nijinsha
Copy link

1.0.0 pre seems to fix this. But now there is no space. There should be least a single space between the end of image and text.

@ngaurav ngaurav mentioned this issue Feb 4, 2020
@ngaurav
Copy link
Contributor Author

ngaurav commented Feb 4, 2020

Hi @Sub6Resources I have created a merge request to address the issue.
@Nijinsha let me know if it works for your use-case.

Sub6Resources added a commit that referenced this issue Feb 8, 2020
@Sub6Resources
Copy link
Owner

Merged the pull request. This will be released with 1.0.0-pre.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants