Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OL & UL not working when RTL #352

Closed
yousifAlneamy opened this issue Jul 12, 2020 · 2 comments
Closed

OL & UL not working when RTL #352

yousifAlneamy opened this issue Jul 12, 2020 · 2 comments

Comments

@yousifAlneamy
Copy link

I was using an older version of this library (^0.11.0) and it was working fine but when upgrading to 1.0.0 the dots & numbers (<li>) started to overlap with the text

How to reproduce

The same example in the documentation with TextDirection.rtl

 Directionality(
                    textDirection: TextDirection.rtl,
                    child: Html(
                      data: htmlData,
                      style: {
                        "html": Style(
                          backgroundColor: Colors.black12,
//              color: Colors.white,
                        ),
//            "h1": Style(
//              textAlign: TextAlign.center,
//            ),
                        "table": Style(
                          backgroundColor:
                              Color.fromARGB(0x50, 0xee, 0xee, 0xee),
                        ),
                        "tr": Style(
                          border:
                              Border(bottom: BorderSide(color: Colors.grey)),
                        ),
                        "th": Style(
                          padding: EdgeInsets.all(6),
                          backgroundColor: Colors.grey,
                        ),
                        "td": Style(
                          padding: EdgeInsets.all(6),
                        ),
                        "var": Style(fontFamily: 'serif'),
                      },
                    ),
                  ),

Screen Shot 2020-07-12 at 2 45 47 PM

@momvart
Copy link
Contributor

momvart commented Aug 18, 2020

I think changing EdgeInsets to EdgeInsetsDirectional and left with start here can solve the problem.

momvart added a commit to momvart/flutter_html that referenced this issue Sep 2, 2020
This will fix list bullets and indentation problems in RTL languages and layout directions.
Related issue: Sub6Resources#352
@erickok
Copy link
Collaborator

erickok commented Feb 8, 2021

fixed by #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants