Handled relative path in image URLs: #146

arnold-parge · 2019-08-23T12:07:11Z

Many web content has relative images paths, which cannot be resolved in flutter_html.
Hence, I have made few changes as below:

added prefixNetworkImageRelativePath in ImageProperties.
HtmlRichTextParser: prefixed node.attributes['src'] with imageProperties.prefixNetworkImageRelativePath

- added prefixNetworkImageRelativePath in ImageProperties. - HtmlRichTextParser: prefixed node.attributes['src'] with imageProperties.prefixNetworkImageRelativePath

The-Redhat · 2019-08-23T12:59:42Z

I think you should implement this feature also for the deprecated HtmlOldParser.

arnold-parge · 2019-08-23T13:33:22Z

I think you should implement this feature also for the deprecated HtmlOldParser.

But HtmlOldParser does not have ImageProperties. Also it is deprecated.

The-Redhat · 2019-08-23T13:46:06Z

Oh sorry you're right. Forgott that

New option: shrinkToFit

…s#75

Version 0.11.0

Sub6Resources

Added my review. Just a couple small things and then we should be good to go!

lib/rich_text_parser.dart

Sub6Resources · 2019-09-13T14:25:23Z

lib/image_properties.dart

@@ -30,5 +31,6 @@ class ImageProperties {
    this.centerSlice,
    this.matchTextDirection = false,
    this.filterQuality = FilterQuality.low,
+    this.prefixNetworkImageRelativePath = ''


Can you add an assert to the constructor that ensures that this is never null?

constructor ImageProperties is const, so it cannot have a body.

lib/image_properties.dart

- added interpolation to prepend image source with prefixImagePath

- added prefixNetworkImageRelativePath in ImageProperties. - HtmlRichTextParser: prefixed node.attributes['src'] with imageProperties.prefixNetworkImageRelativePath

- added interpolation to prepend image source with prefixImagePath

Sub6Resources · 2019-10-07T23:54:50Z

Do you mind squashing your commits so this is a bit easier to review?

andy1xx8 · 2020-03-28T06:27:45Z

I dont think this is what flutter html should handle.
As developer have to resolve relative paths on their own first.
Before u give it to flutter html. Let's Flutter Html does his job only.

tneotia · 2021-02-04T15:26:38Z

Hi there, thanks for this PR! It looks like this code applies to the old parser and thus is incompatible with the latest changes on the branch. As a result, we may close this PR.
However, with #505, we have finally added this capability into the library with a custom image rendering API (much better than the current customRender). You can see the discussion at #497 to see how it works. If you have any suggestions, please let @erickok know there. Again thanks for contributing! :)

…ender API Fixes Sub6Resources#153 and closes Sub6Resources#146

erickok · 2021-02-08T22:25:11Z

See #532 for an example on how to use relative paths with the new custom image render API.

Handled relative path in image urls:

d560278

- added prefixNetworkImageRelativePath in ImageProperties. - HtmlRichTextParser: prefixed node.attributes['src'] with imageProperties.prefixNetworkImageRelativePath

arnold-parge closed this Aug 23, 2019

arnold-parge reopened this Aug 23, 2019

Sub6Resources self-requested a review August 26, 2019 17:43

Sub6Resources added enhancement New feature or request high-priority labels Aug 26, 2019

Sub6Resources self-assigned this Aug 26, 2019

amake and others added 7 commits August 27, 2019 07:04

Implement li leading char as TextSpan rather than separate widget

2039240

Add shrinkToFit option to shrink Html to its natural content width

4ee8640

Update test image URL

ac97ee9

Organize imports

431a08f

Create CONTRIBUTING.md

a671d94

change parse to tryParse in image width. Fixes Sub6Resources#118

c5278bb

Allow negative numbers to fix Sub6Resources#97

247a8f3

Sub6Resources mentioned this pull request Sep 7, 2019

Relative url addresses in <a> and <img> support #153

Closed

Sub6Resources added 11 commits September 9, 2019 08:20

Fix image alt attribute (fixes Sub6Resources#96)

f1fe495

Add partial support for sub and remove unused functions

f38b56f

Merge branch '0.11.0' into shrink-to-fit

059bfe0

Merge pull request Sub6Resources#148 from amake/shrink-to-fit

52c8927

New option: shrinkToFit

Update readme for latest merged pr to show that it fixes Sub6Resource…

18950af

…s#75

Prepare for release

2e4d2ab

Merge pull request Sub6Resources#152 from Sub6Resources/0.11.0

a7aa1fd

Version 0.11.0

Add golden tests for all supported html elements

846ae21

Add check for flutter version in tests

c28db9f

Add screenshot to readme

b8644ec

Add check for null onLinkTap callback

d55aa45

Sub6Resources requested changes Sep 13, 2019

View reviewed changes

Sub6Resources and others added 5 commits September 13, 2019 17:19

Try to fix golden tests

9892279

Check that files are loaded correctly in circleci

213efa0

Update golden files

6854229

- Refactored prefixNetworkImageRelativePath -> prefixImagePath

573705e

- added interpolation to prepend image source with prefixImagePath

Handled relative path in image urls:

fe51711

- added prefixNetworkImageRelativePath in ImageProperties. - HtmlRichTextParser: prefixed node.attributes['src'] with imageProperties.prefixNetworkImageRelativePath

arnold-parge requested a review from Sub6Resources September 18, 2019 10:31

Arnold Parge added 3 commits September 18, 2019 17:06

- Refactored prefixNetworkImageRelativePath -> prefixImagePath

2d0bb5e

- added interpolation to prepend image source with prefixImagePath

Merge branch 'master' of https://github.com/arnold-parge/flutter_html

5ea2907

fixed space in imageUrl

b0df4a3

tneotia mentioned this pull request Jan 17, 2021

Custom Image API #503

Closed

erickok added a commit to vrtdev/flutter_html that referenced this pull request Feb 8, 2021

Support relative paths for network image rendering via custom image r…

02465f6

…ender API Fixes Sub6Resources#153 and closes Sub6Resources#146

erickok mentioned this pull request Feb 8, 2021

Support relative paths for network image rendering #532

Merged

erickok closed this Feb 8, 2021

fahami mentioned this pull request Oct 12, 2022

[BUG] Table not showing #685

Closed

Equirinya mentioned this pull request Aug 5, 2023

[BUG] <p> tags within table results in the HTML widget disappearing #1351

Open

priyankgandhi0 mentioned this pull request Mar 12, 2024

The following LateError was thrown building Html(state: _HtmlState#1efc6): LateInitializationError: Field '_currentProperty@1686066930' has not been initialized. #1415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handled relative path in image URLs: #146

Handled relative path in image URLs: #146

arnold-parge commented Aug 23, 2019

The-Redhat commented Aug 23, 2019

arnold-parge commented Aug 23, 2019

The-Redhat commented Aug 23, 2019

Sub6Resources left a comment

Sub6Resources Sep 13, 2019

arnold-parge Sep 18, 2019

Sub6Resources commented Oct 7, 2019

andy1xx8 commented Mar 28, 2020 •

edited

Loading

tneotia commented Feb 4, 2021

erickok commented Feb 8, 2021

Handled relative path in image URLs: #146

Handled relative path in image URLs: #146

Conversation

arnold-parge commented Aug 23, 2019

The-Redhat commented Aug 23, 2019

arnold-parge commented Aug 23, 2019

The-Redhat commented Aug 23, 2019

Sub6Resources left a comment

Choose a reason for hiding this comment

Sub6Resources Sep 13, 2019

Choose a reason for hiding this comment

arnold-parge Sep 18, 2019

Choose a reason for hiding this comment

Sub6Resources commented Oct 7, 2019

andy1xx8 commented Mar 28, 2020 • edited Loading

tneotia commented Feb 4, 2021

erickok commented Feb 8, 2021

andy1xx8 commented Mar 28, 2020 •

edited

Loading