Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-parser]Support ruby element. #178

Merged
merged 1 commit into from
Dec 12, 2019
Merged

[new-parser]Support ruby element. #178

merged 1 commit into from
Dec 12, 2019

Conversation

dotneet
Copy link
Contributor

@dotneet dotneet commented Oct 23, 2019

Support ruby, rt with correct position.

スクリーンショット 2019-10-23 18 20 48

@dotneet dotneet mentioned this pull request Oct 23, 2019
Closed
@dotneet dotneet changed the title Support ruby element. [new-parser]Support ruby element. Oct 23, 2019
@Sub6Resources
Copy link
Owner

Thanks for the pull request! I'll work on reviewing this and getting it merged if everything looks okay.

@Sub6Resources Sub6Resources self-requested a review October 23, 2019 13:45
@Sub6Resources Sub6Resources self-assigned this Oct 23, 2019
@Sub6Resources Sub6Resources added 1.0.0 enhancement New feature or request labels Oct 23, 2019
@Sub6Resources Sub6Resources added this to the 1.0.0 milestone Oct 23, 2019
@Larpoux
Copy link

Larpoux commented Nov 12, 2019 •
edited
Loading

I hope that it will not be too difficult to fix this issue. I really need a way to display Furigana (ruby tag)

@ttpho
Copy link

ttpho commented Nov 22, 2019

@dotneet this is awesome pull request. 🙇

Sub6Resources
Sub6Resources approved these changes Dec 12, 2019
View reviewed changes
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple small issues with rendering, but I think enough people need this feature that we can merge it and I'll fix those issues ASAP.

@Sub6Resources Sub6Resources merged commit f52af25 into Sub6Resources:new-parser Dec 12, 2019
@Sub6Resources Sub6Resources mentioned this pull request Dec 14, 2019
Closed
@Equirinya Equirinya mentioned this pull request Aug 5, 2023
Open
@priyankgandhi0 priyankgandhi0 mentioned this pull request Mar 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sub6Resources Sub6Resources Sub6Resources approved these changes

Assignees

@Sub6Resources Sub6Resources

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dotneet @Sub6Resources @Larpoux @ttpho