Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a custom function for creating image widgets #183

Closed
wants to merge 1 commit into from
Closed

Added a custom function for creating image widgets #183

wants to merge 1 commit into from

Conversation

LeeMatthewHiggins
Copy link

No description provided.

This was referenced Dec 14, 2019
Merged
Closed
@maheshbhattaraai
Copy link

How can we show cached network image

maheshbhattaraai
maheshbhattaraai reviewed Dec 15, 2019
View reviewed changes
Copy link

@maheshbhattaraai maheshbhattaraai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working in flutter 1.10

erickok
erickok reviewed Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, you could implement this with a custom tag renderer, especially when #384 is merged.

@erickok
Copy link
Collaborator

erickok commented Jan 15, 2021

Let's discuss: #497

@tneotia tneotia mentioned this pull request Jan 17, 2021
Closed
@tneotia
Copy link
Collaborator

tneotia commented Feb 4, 2021

Hi there, thanks for this PR! It looks like this code applies to the old parser and thus is incompatible with the latest changes on the branch. As a result, we may close this PR.
However, with #505, we have finally added this capability into the library with a custom image rendering API (much better than the current customRender). You can see the discussion at #497 to see how it works. If you have any suggestions, please let @erickok know there. Again thanks for contributing! :)

@erickok
Copy link
Collaborator

erickok commented Feb 8, 2021

Please see the new image render API, with several examples in the README.

Fixed via #505.

@erickok erickok closed this Feb 8, 2021
@Equirinya Equirinya mentioned this pull request Aug 5, 2023
Open
@priyankgandhi0 priyankgandhi0 mentioned this pull request Mar 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickok erickok erickok left review comments

@maheshbhattaraai maheshbhattaraai maheshbhattaraai left review comments

@Sub6Resources Sub6Resources Awaiting requested review from Sub6Resources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeeMatthewHiggins @maheshbhattaraai @erickok @tneotia