Add bullet points to <ul> list items #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub6Resources
requested changes
Sep 9, 2018
lib/html_parser.dart
Outdated
| return Container( | ||
| width: width, | ||
| child: Wrap( | ||
| children: _parseNodeList(node.nodes), | ||
| child: Row( |
There was a problem hiding this comment.
If you could change this from Row to Wrap that would be great. (Otherwise lines will overflow to the right rather than wrapping when they get long)
|
Done! |
Sub6Resources
approved these changes
Sep 10, 2018
|
Looks great! I'll work on merging this a little later today. |
|
This has been published as Version 0.7.0 (bd19c57) on pub. Thanks again for the pull request! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for <ul> (and <li>) to include bullet points.
They now look like this:
Haven't done ordered lists however there is a switch case for <ol> in the list item case which just uses the same as unordered list (bullet point) for now.