-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossAxisAlignment parameter #255
Add crossAxisAlignment parameter #255
Conversation
I appreciate the pull request, however the rich text parser is set to be deprecated soon and these changes would immediately become obsolete. Also, do you have a specific issue this fixes? |
That's strange that everything is centered to begin with. I don't believe this is an issue on the new-parser branch, since everything is aligned using the |
I'll try and see if it's a problem with the new parser. |
I had a quick look, and it seems that on the new pre-release version the list items are next to each other horizontally, all on the same line. But I'm having other issues because I had to go back to Flutter stable to try it out (was on master), because the pre-release of flutter_html seems to depend on an older flutter_svg which does not work on master. But that's a different issue, of course. But it shouldn't happen that list items are all on the same line horizontally, right? |
Yeah, there shouldn't be horizontal list items. I'm not seeing that when I run my example projects. Do you mind posting a bit of sample code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi there, thanks for this PR! It looks like this code applies to the old parser and thus is incompatible with the latest changes on the branch. It also seems that this is no longer an issue when using the new parser (v1.0.0+), so we may close this PR. Again, thanks for contributing! :) |
The default is
CrossAxisAlignment.center
to make it a non-breaking change.