Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossAxisAlignment parameter #255

Closed

Conversation

wilkomanger
Copy link

@wilkomanger wilkomanger commented Mar 31, 2020

The default is CrossAxisAlignment.center to make it a non-breaking change.

@Sub6Resources
Copy link
Owner

I appreciate the pull request, however the rich text parser is set to be deprecated soon and these changes would immediately become obsolete. Also, do you have a specific issue this fixes?

@wilkomanger
Copy link
Author

Ah, okay. The issue is that by default everything is centered:
image

And I need this:
image

Which is made possible with this PR when passing crossAxisAlignment: CrossAxisAlignment.start.

If you want I can do it as a PR for the new parser!

@Sub6Resources
Copy link
Owner

That's strange that everything is centered to begin with. I don't believe this is an issue on the new-parser branch, since everything is aligned using the Style objects alignment. If it is actually an issue, do you have some sample code so that I can replicate it?

@wilkomanger
Copy link
Author

I'll try and see if it's a problem with the new parser.

@wilkomanger
Copy link
Author

I had a quick look, and it seems that on the new pre-release version the list items are next to each other horizontally, all on the same line.

But I'm having other issues because I had to go back to Flutter stable to try it out (was on master), because the pre-release of flutter_html seems to depend on an older flutter_svg which does not work on master. But that's a different issue, of course.

But it shouldn't happen that list items are all on the same line horizontally, right?

@Sub6Resources
Copy link
Owner

Yeah, there shouldn't be horizontal list items. I'm not seeing that when I run my example projects. Do you mind posting a bit of sample code?

Copy link

@blunderous blunderous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tneotia
Copy link
Collaborator

tneotia commented Feb 4, 2021

Hi there, thanks for this PR! It looks like this code applies to the old parser and thus is incompatible with the latest changes on the branch. It also seems that this is no longer an issue when using the new parser (v1.0.0+), so we may close this PR. Again, thanks for contributing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants