Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with images not loading when inside of p tag #5

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

loitran
Copy link
Contributor

@loitran loitran commented Aug 15, 2018

No description provided.

Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that issue! If you could just adjust the padding so that it matches the default browser css styles (see requested change) I'll merge this and release it.

style: defaultTextStyle,
));
return Padding(
padding: EdgeInsets.only(bottom: 10.0),
Copy link
Owner

@Sub6Resources Sub6Resources Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set the padding to 14.0 on both the top and bottom to match other block elements?

@Sub6Resources Sub6Resources self-assigned this Aug 15, 2018
@Sub6Resources Sub6Resources added this to the 0.4.1 milestone Aug 15, 2018
@Sub6Resources
Copy link
Owner

Will fix #6

@Sub6Resources Sub6Resources added bugfix Fixes a bug in the package requested-changes labels Aug 15, 2018
@loitran
Copy link
Contributor Author

loitran commented Aug 15, 2018

@Sub6Resources updated branch

Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks. This will be published as version 0.4.1.

@Sub6Resources Sub6Resources merged commit 9ef6d28 into Sub6Resources:master Aug 15, 2018
@Sub6Resources
Copy link
Owner

Version 0.4.1 has been released. Thanks again @loitran!

@fahami fahami mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants