Fix leading and trailing whitespaces issue #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good - I understand what you did to solve this. But yes, this would need a bit of regression testing. Really we should set up proper golden/widget tests again... (wish I had more time right now). |
|
I tested this and indeed the issues seem fixed. I also don't see any obvious regressions (again... I wil have to set up proper golden tests some time in the future). Only thing I noticed is that lists no longer seem to be rendered correctly in the example app but this is unrelated as it also is bugged in master.
|
erickok
approved these changes
Mar 16, 2021
|
I was on |
|
Nope it's working as expected:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
This will need some testing, I threw all the problem cases from #347 and #398 and it works fine.